Tom Smeding
6bbc646e6f
Fix bug in mempool get_transaction_stats histogram calculation
...
The 98th percentile position in the agebytes map was incorrectly
calculated: it assumed the transactions in the mempool all have unique
timestamps at second-granularity. This commit fixes this by correctly
finding the right cumulative number of transactions in the map suffix.
This bug could lead to an out-of-bounds write in the rare case that
all transactions in the mempool were received (and added to the mempool)
at a rate of at least 50 transactions per second. (More specifically,
the number of *unique* receive_time values, which have second-
granularity, must be at most 2% of the number of transactions in the
mempool for this crash to trigger.) If this condition is satisfied, 'it'
points to *before* the agebytes map, 'delta' gets a nonsense value, and
the value of 'i' in the first stats.histo-filling loop will be out of
bounds of stats.histo.
2019-08-28 16:46:31 +02:00
luigi1111
85014813cf
Merge pull request #5707
...
3a0451a
MLSAG speedup and additional checks (SarangNoether)
2019-08-28 02:22:00 -05:00
luigi1111
46c1198fd7
Merge pull request #5844
...
a7d1577
build: fix depends Travis ncurses build, don't wipe CONFIG_SHELL (xiphon)
2019-08-27 15:23:08 -05:00
Sarang Noether
3a0451a8be
MLSAG speedup and additional checks
2019-08-27 16:22:44 -04:00
luigi1111
174c3a05f6
Merge pull request #5820
...
ac0a229
Fix Android build in Docker (hyperreality)
2019-08-27 15:22:08 -05:00
luigi1111
a387f0390d
Merge pull request #5794
...
a63e212
Docker updated dependencies cmake boost sodium cppzmq udev protobuf zmq (homdx)
2019-08-27 15:21:17 -05:00
luigi1111
f68512e9e4
Merge pull request #5729
...
7c894fc
device_ledger: add paranoid buffer overflow check (moneromooo-monero)
f07524b
device_ledger: fix uninitialized additional_key (moneromooo-monero)
2019-08-27 15:19:47 -05:00
luigi1111
8f6f674753
Merge pull request #5609
...
1dc3b1a
wallet: add --extra-entropy command line flag (moneromooo-monero)
2019-08-27 15:14:15 -05:00
luigi1111
3e80f44503
Merge pull request #5559
...
33e91e1
wallet, rpc: add a release field to get_version (moneromooo-monero)
2019-08-27 15:09:37 -05:00
luigi1111
3254204fb9
Merge pull request #5416
...
63186a0
Wallet: Option to export data to ASCII (tmoravec)
2019-08-27 15:02:55 -05:00
xiphon
082730b6e5
daemon: automatic public nodes discovering and bootstrap daemon switching
2019-08-27 12:01:49 +00:00
Matyas Liptak
f56e160217
unit_tests: Fix uninitialized values
...
- Initialize the `hash` in the `get_block_hash()` function of the
`output_distribution` unit test explicitly, to silence `valgrind`
warnings.
2019-08-27 09:17:34 +02:00
hyperreality
5f4bd92e06
Fix Travis build on Windows + Mac
...
Following 13c0b8c
, the unwind package is being attempted to be built on
Windows and Mac when it should only be built on Linux.
2019-08-27 00:41:03 +01:00
moneromooo-monero
33e91e1a1e
wallet, rpc: add a release field to get_version
...
It does not leak much since you can make a fair guess by RPC
version already, and some people want to avoid non release
clients when using third parties' nodes (because they'd never
lie about it)
2019-08-26 19:28:25 +00:00
Howard Chu
e907305c6c
ITS#9068 fix backslash escaping
...
mdb_load wasn't properly inserting escaped backslashes into the data.
mdb_dump wasn't escaping backslashes when generating printable output.
2019-08-26 17:59:13 +01:00
moneromooo-monero
f07524b56b
device_ledger: fix uninitialized additional_key
...
Coverity 200185
2019-08-26 12:50:29 +00:00
moneromooo-monero
7c894fc7fd
device_ledger: add paranoid buffer overflow check
...
Coverity 200183
2019-08-26 12:50:26 +00:00
moneromooo-monero
2cb22d4071
core: make the "update probably needed soon" message less scary
2019-08-26 07:56:55 +00:00
erciccione
cbdd76d513
readme: remove snap monero package and add debian
2019-08-25 17:22:02 +02:00
moneromooo-monero
c4da1a25c3
wallet2: fix unset_ring tx retrieval checks
2019-08-24 14:46:31 +00:00
moneromooo-monero
87d2f063af
simplewallet: moan harder about untrusted nodes
2019-08-24 12:36:10 +00:00
moneromooo-monero
b51f4cdcaf
daemon: add pruned and publicrpc flags to print_pl
2019-08-23 19:15:45 +00:00
moneromooo-monero
894cc81e83
wallet2: fix cold signing losing tx keys
2019-08-23 16:38:20 +00:00
xiphon
063eebbd43
daemon: implement 'set_bootstrap_daemon' command
2019-08-23 12:09:02 +00:00
Tom Smeding
a84aa04d57
syncobj.h no longer defines shared_guard, so remove those define's
...
The removed preprocessor macro's refer to types that are not defined in
the file anymore; the only other place where shared_guard is defined is
in winobj.h, which also defines the same macro's. Therefore, this change
is safe.
(Side note is that these macro's weren't used at all anyway, but that is
orthogonal to the issue.)
2019-08-23 08:42:36 +02:00
xiphon
a7d1577545
build: fix depends Travis ncurses build, don't wipe CONFIG_SHELL
2019-08-23 01:55:33 +00:00
moneromooo-monero
cae488dc9b
p2p: reject incoming connections to self
2019-08-22 17:08:29 +00:00
Tadeas Moravec
63186a01ce
Wallet: Option to export data to ASCII
...
New CLI wallet variable: export-format with options "binary" (the default),
or "ascii". "Binary" behaves as before, "ascii" forces the wallet to convert
data to ASCII using base64.
Reading files from the disk tries to auto detect what format has been
used (using a magic string added when exporting the data).
Implements https://github.com/monero-project/monero/issues/2859
2019-08-22 16:03:22 +02:00
stoffu
50813c103e
ringdb: fix bug in blackballing
2019-08-22 21:34:48 +09:00
stoffu
2425f27acd
blockchain_blackball: use is_output_spent instead of ringdb.blackballed for spentness test
2019-08-22 21:34:47 +09:00
stoffu
9f68669503
blockchain_blackball: add --historical-stat which prints historical stats of spent ratio
2019-08-22 21:34:40 +09:00
moneromooo-monero
1dc3b1a516
wallet: add --extra-entropy command line flag
...
It lets the user add custom entropy to the PRNG.
It does this by hashing the new data and xoring the resulting
hash with the PRNG state.
2019-08-22 11:12:57 +00:00
luigi1111
cdfa2e58df
Merge pull request #5827
...
30779de
fix feature not introduced until boost 1.66 (jtgrassie)
2019-08-21 15:54:10 -05:00
luigi1111
2be47ae02a
Merge pull request #5817
...
50ec40e
Increase max_dbs from 20 to 32 (hyc)
2019-08-21 15:49:51 -05:00
luigi1111
7bdff6005f
Merge pull request #5815
...
adc16d2
Fix check for disconnecting peers when syncing (jagerman)
2019-08-21 15:48:09 -05:00
luigi1111
d8244eb39c
Merge pull request #5808
...
5a91b83
simplewallet: add a few missing settings help text (stoffu)
ae7bf37
simplewallet: fix arg indexing bug in set_device_name (stoffu)
2019-08-21 15:41:42 -05:00
luigi1111
0a42fddde4
Merge pull request #5807
...
4b1df4e
Fix for biased signature nonce (SarangNoether)
2019-08-21 15:38:35 -05:00
luigi1111
28e0a28b96
Merge pull request #5800
...
6ca033d
hid_error() could return a null, which causes the program to crash with (TheQuantumPhysicist)
2019-08-21 15:36:05 -05:00
luigi1111
d035af8e92
Merge pull request #5788
...
de5038f
unpushed languages from pootle (synced) (Monero-Weblate)
2019-08-21 15:33:14 -05:00
luigi1111
11ab328ce3
Merge pull request #5778
...
8703aa5
MMS: Use chans instead of normal addresses for auto-config (rbrunner7)
2019-08-21 15:31:11 -05:00
luigi1111
415005aceb
Merge pull request #5777
...
757b789
Define _WANT_SEMUN for FreeBSD to ensure union semun is defined (odonnellnoel)
2019-08-21 15:28:10 -05:00
luigi1111
17f1ac8a42
Merge pull request #5775
...
95bebb1
Add nbproject directory to .gitignore (odonnellnoel)
2019-08-21 15:27:06 -05:00
luigi1111
f1e66a03f1
Merge pull request #5757
...
a12ca68
translations: add a ready file to control which translations to build (moneromooo-monero)
2019-08-21 15:25:18 -05:00
luigi1111
eea0123de4
Merge pull request #5755
...
7a3e458
improve tx_sanity_check clarification (vicsn)
2019-08-21 15:23:58 -05:00
luigi1111
5aa65adfcf
Merge pull request #5735
...
32b0560
easylogging++: weed out most calls to allowed without locking (moneromooo-monero)
2019-08-21 15:21:51 -05:00
luigi1111
1bd3f1a1fb
Merge pull request #5750
...
884df82
wallet: provide original address for outgoing transfers (xiphon)
2019-08-21 15:20:51 -05:00
luigi1111
0ca1a51033
Merge pull request #5749
...
45c28d8
build: fix OSX static libusb check and link against static libobjc (xiphon)
2019-08-21 15:19:33 -05:00
luigi1111
a8e99198bf
Merge pull request #5748
...
b350726
boost: update obsolete usage of endian API (moneromooo-monero)
2019-08-21 15:18:38 -05:00
luigi1111
de30131abd
Merge pull request #5743
...
65f29a8
simplewallet: add restore_height command (tobtoht)
2019-08-21 15:17:26 -05:00
luigi1111
b488ee8188
Merge pull request #5742
...
0d916a6
Fix incorrectly named binding for MMS send_signer_config command (tobtoht)
2019-08-21 15:13:16 -05:00